[Sahana_proj] [Not Sent from Trinity College] Re: Conflicts with Sahana coding guidelines

[Ralph Morelli]

Hi Glenn,

Good question!

If I understand your question, you're asking about the code itself,  
not the look-and-feel of the calendar, which (I'm assuming) uses the  
Sahana CSS tags and so looks like any other Sahana page.   So the  
question is whether code that doesn't conform to the Sahana coding  
guidelines would be acceptable in a Sahana module.

I think the answer to this is "it depends on the details".   If there  
are minor differences in the coding guidelines, such that the  
module's functionality does not become problematic as new releases of  
Sahana are made, then that should not be a problem. On the other  
hand, if the differences are great enough that functionality or  
compatibility become issues, then it should probably be revised.   
These are the kinds of questions/decisions that would be made by the  
core team when they review your code.  For example, in our VM module,  
we used a piece of code that we found on the net to implement a pop- 
up calendar that allows the user to select a date.  The core team  
rejected that and asked us to revise the code to use Sahana's pop-up.

I'm posting this on the list serve so that others can chime in. You  
might also consider posting more specifics about the code in  
question, as these things really are decided on a case-by-case basis.

Regards,
-- ram



On Apr 24, 2007, at 11:48 PM, Marmon, Glenn D. wrote:

> For our ERM project, we have been working essentially with two open  
> source pieces of software - the Sahana framework and Owen  
> Raccuglia's visual calendar. We can get both working great, and  
> have had a lot of success getting them to work together (at least  
> from the user's standpoint). Essentially, right now all of the  
> pages follow sahana guidelines fine as far as we know, except when  
> the visual calendars need to be displayed - those are done by  
> creating an iframe on the Sahana page that brings up a PHP file  
> generated by the visual calendar software.
>
> Basically, our concern is this - since the PHP and CSS files for  
> the visual calendar have been created from a different open source  
> project all together, they don't comply to Sahana's coding  
> standards, yet we are including them in a project intended to be  
> used in the Sahana framework. From what you already know about  
> Sahana modules, do you believe that this is acceptable in a sahana  
> project like ours?
>
> Thanks,
> -Glenn

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.trincoll.edu/pipermail/sahana_proj/attachments/20070425/31876240/attachment.htm