<HTML><BODY style="word-wrap: break-word; -khtml-nbsp-mode: space; -khtml-line-break: after-white-space; ">Hi Glenn,<DIV><BR class="khtml-block-placeholder"></DIV><DIV>Good question!</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>If I understand your question, you're asking about the code itself, not the look-and-feel of the calendar, which (I'm assuming) uses the Sahana CSS tags and so looks like any other Sahana page. So the question is whether code that doesn't conform to the Sahana coding guidelines would be acceptable in a Sahana module. </DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>I think the answer to this is "it depends on the details". If there are minor differences in the coding guidelines, such that the module's functionality does not become problematic as new releases of Sahana are made, then that should not be a problem. On the other hand, if the differences are great enough that functionality or compatibility become issues, then it should probably be revised. These are the kinds of questions/decisions that would be made by the core team when they review your code. For example, in our VM module, we used a piece of code that we found on the net to implement a pop-up calendar that allows the user to select a date. The core team rejected that and asked us to revise the code to use Sahana's pop-up.</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>I'm posting this on the list serve so that others can chime in. You might also consider posting more specifics about the code in question, as these things really are decided on a case-by-case basis.</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>Regards,</DIV><DIV><DIV> <SPAN class="Apple-style-span" style="border-collapse: separate; border-spacing: 0px 0px; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; text-align: auto; -khtml-text-decorations-in-effect: none; text-indent: 0px; -apple-text-size-adjust: auto; text-transform: none; orphans: 2; white-space: normal; widows: 2; word-spacing: 0px; "><SPAN class="Apple-style-span" style="border-collapse: separate; border-spacing: 0px 0px; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; text-align: auto; -khtml-text-decorations-in-effect: none; text-indent: 0px; -apple-text-size-adjust: auto; text-transform: none; orphans: 2; white-space: normal; widows: 2; word-spacing: 0px; "><DIV>-- ram</DIV><DIV><BR class="khtml-block-placeholder"></DIV><BR class="Apple-interchange-newline"></SPAN></SPAN> </DIV><BR><DIV><DIV>On Apr 24, 2007, at 11:48 PM, Marmon, Glenn D. wrote:</DIV><BR class="Apple-interchange-newline"><BLOCKQUOTE type="cite"><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">For our ERM project, we have been working essentially with two open source pieces of software - the Sahana framework and Owen Raccuglia's visual calendar. We can get both working great, and have had a lot of success getting them to work together (at least from the user's standpoint). Essentially, right now all of the pages follow sahana guidelines fine as far as we know, except when the visual calendars need to be displayed - those are done by creating an iframe on the Sahana page that brings up a PHP file generated by the visual calendar software.</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; min-height: 14px; "><BR></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">Basically, our concern is this - since the PHP and CSS files for the visual calendar have been created from a different open source project all together, they don't comply to Sahana's coding standards, yet we are including them in a project intended to be used in the Sahana framework. From what you already know about Sahana modules, do you believe that this is acceptable in a sahana project like ours?</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; min-height: 14px; "><BR></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">Thanks,</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">-Glenn</DIV> </BLOCKQUOTE></DIV><BR></DIV></BODY></HTML>